Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump csharpier from 0.26.7 to 0.27.0 #212

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 22, 2024

Bumps csharpier from 0.26.7 to 0.27.0.

Release notes

Sourced from csharpier's releases.

0.27.0

What's Changed

Improve formatting of lambda expressions #1066

Many thanks go to @​Rudomitori for contributing a number of improvements to the formatting of lambda expressions.

Some examples of the improvements.

// input
var affectedRows = await _dbContext.SomeEntities
    .ExecuteUpdateAsync(
        x => 
            x.SetProperty(x => x.Name, x => command.NewName)
                .SetProperty(x => x.Title, x => command.NewTItle)
                .SetProperty(x => x.Count, x => x.Command.NewCount)
    );
// 0.27.0
var affectedRows = await _dbContext.SomeEntities
.ExecuteUpdateAsync(x =>
x.SetProperty(x => x.Name, x => command.NewName)
.SetProperty(x => x.Title, x => command.NewTItle)
.SetProperty(x => x.Count, x => x.Command.NewCount)
);

// input
builder.Entity<IdentityUserToken<string>>(b =>
{
    b.HasKey(
        l =>
            new
            {
                l.UserId,
                l.LoginProvider,
                l.Name
            }
    );
    b.ToTable("AspNetUserTokens");
});
// 0.27.0
builder.Entity<IdentityUserToken<string>>(b =>
{
b.HasKey(l => new
{
l.UserId,
l.LoginProvider,
l.Name
});
</tr></table>

... (truncated)

Changelog

Sourced from csharpier's changelog.

# 0.27.0

What's Changed

Improve formatting of lambda expressions #1066

Many thanks go to @​Rudomitori for contributing a number of improvements to the formatting of lambda expressions.

Some examples of the improvements.

// input
var affectedRows = await _dbContext.SomeEntities
    .ExecuteUpdateAsync(
        x => 
            x.SetProperty(x => x.Name, x => command.NewName)
                .SetProperty(x => x.Title, x => command.NewTItle)
                .SetProperty(x => x.Count, x => x.Command.NewCount)
    );
// 0.27.0
var affectedRows = await _dbContext.SomeEntities
.ExecuteUpdateAsync(x =>
x.SetProperty(x => x.Name, x => command.NewName)
.SetProperty(x => x.Title, x => command.NewTItle)
.SetProperty(x => x.Count, x => x.Command.NewCount)
);

// input
builder.Entity<IdentityUserToken<string>>(b =>
{
    b.HasKey(
        l =>
            new
            {
                l.UserId,
                l.LoginProvider,
                l.Name
            }
    );
    b.ToTable("AspNetUserTokens");
});
// 0.27.0
builder.Entity<IdentityUserToken<string>>(b =>
{
b.HasKey(l => new
{
l.UserId,
l.LoginProvider,
l.Name
});
</tr></table>

... (truncated)

Commits
  • 7d09173 Releasing 0.27.0 (#1128)
  • 99206da Adding GRPC support to CSharpier to allow better communication with extension...
  • 102c6e5 Fixing issue with #if being eaten in collection expression (#1120)
  • 207353a Allowing new lines in initializers (#1113)
  • b634ee3 fixing some issues with the recent raw string literal changes from #975 (#1106)
  • 3c8022c Only sort modifiers that we know should be sorted. (#1124)
  • bbbbbab Some syntax finder tweaks made while tracking down what modifiers look like o...
  • 69dc6ef Cleaning up syntax finder a bit. Add readme (#1121)
  • 0f07ce0 update doc
  • f49cf5d Minor update to EditorsTroubleshooting.md (#1118)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @guibranco.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file nuget Refers to nuget packages packages Packages labels Jan 22, 2024
@dependabot dependabot bot requested a review from guibranco January 22, 2024 01:59
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2024
@guibranco guibranco enabled auto-merge (squash) January 22, 2024 02:00
Copy link
Owner

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@guibranco
Copy link
Owner

@dependabot squash and merge

@dependabot dependabot bot force-pushed the dependabot/nuget/csharpier-0.27.0 branch from e2ae894 to 38c7a2c Compare January 22, 2024 02:10
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 22, 2024

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Bumps [csharpier](https://github.com/belav/csharpier) from 0.26.7 to 0.27.0.
- [Release notes](https://github.com/belav/csharpier/releases)
- [Changelog](https://github.com/belav/csharpier/blob/main/CHANGELOG.md)
- [Commits](belav/csharpier@0.26.7...0.27.0)

---
updated-dependencies:
- dependency-name: csharpier
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/nuget/csharpier-0.27.0 branch from 38c7a2c to 43a6ff5 Compare January 22, 2024 02:29
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7618215) 1774 4 0.23%
Head commit (43a6ff5) 1774 (+0) 4 (+0) 0.23% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#212) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@AppVeyorBot
Copy link

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7618215) 0.22% compared to head (43a6ff5) 0.22%.

❗ Current head 43a6ff5 differs from pull request most recent head bfe8027. Consider uploading reports for the commit bfe8027 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #212   +/-   ##
=====================================
  Coverage   0.22%   0.22%           
=====================================
  Files        117     117           
  Lines       1774    1774           
  Branches      75      75           
=====================================
  Hits           4       4           
+ Misses      1770    1768    -2     
- Partials       0       2    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guibranco
Copy link
Owner

@gstraccini csharpier

Copy link
Contributor

gstraccini bot commented Jan 22, 2024

Running CSharpier on this branch! 🔧

Copy link
Contributor

gstraccini bot commented Jan 22, 2024

CSharpier result:

Error ./Src/VTEX/Transport/PCIPayment.cs - Was not formatted.
  ----------------------------- Expected: Around Line 38 -----------------------------
          public PCIPaymentField GetFieldByName([Localizable(false)] string fieldName) =>
              Fields.SingleOrDefault(f =>
                  f.Name.Equals(fieldName, StringComparison.InvariantCultureIgnoreCase)
  ----------------------------- Actual: Around Line 38 -----------------------------
          public PCIPaymentField GetFieldByName([Localizable(false)] string fieldName) =>
              Fields.SingleOrDefault(
                  f => f.Name.Equals(fieldName, StringComparison.InvariantCultureIgnoreCase)
  

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7618215) 1774 4 0.23%
Head commit (bfe8027) 1774 (+0) 4 (+0) 0.23% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#212) 2 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

@AppVeyorBot
Copy link

Build VTEX-SDK-dotnet 2.3.587 completed (commit 618f067278 by @)

@guibranco guibranco merged commit 71d2a4e into main Jan 22, 2024
20 checks passed
@guibranco guibranco deleted the dependabot/nuget/csharpier-0.27.0 branch January 22, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code nuget Refers to nuget packages packages Packages size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants